Add comments about redundant annotations - #1404
Merged
KFilipek merged 1 commit intoJul 4, 2025
Merged
Conversation
ldorau
changed the title
Contributor
Author
11 tasks
ldorau
force-pushed
the
Add_missing_utils_annotate_memory_inaccessible
branch
from
July 2, 2025 09:00
d0417ec to
b7c33a1
Compare
ldorau
marked this pull request as ready for review
July 2, 2025 09:00
Contributor
|
Is it all missing annotations? We should mark memory as inaccessible after mmap, and only then mark it as undefined/defined, when given to the user. |
KFilipek
approved these changes
Jul 2, 2025
Contributor
Author
@lplewa I think they are. Do you see any missing left? |
ldorau
force-pushed
the
Add_missing_utils_annotate_memory_inaccessible
branch
from
July 3, 2025 13:59
b7c33a1 to
7bc845a
Compare
Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
ldorau
force-pushed
the
Add_missing_utils_annotate_memory_inaccessible
branch
from
July 4, 2025 06:01
7bc845a to
f1344d3
Compare
ldorau
changed the title
bratpiorka
approved these changes
Jul 4, 2025
KFilipek
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add comments about redundant annotations.
Checklist